Skip to content

ref(nextjs): Change url of parser base to make security scanners less sus #14695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2024
Merged

ref(nextjs): Change url of parser base to make security scanners less sus #14695

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,8 @@ export function appRouterInstrumentNavigation(client: Client): void {

function transactionNameifyRouterArgument(target: string): string {
try {
return new URL(target, 'http://some-random-base.com/').pathname;
// We provide an arbitrary base because we only care about the pathname and it makes URL parsing more resilient.
return new URL(target, 'http://example.com/').pathname;
} catch {
return '/';
}
Expand Down
Loading