Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/browser/src/transports/offline.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import type { BaseTransportOptions, Envelope, OfflineStore, OfflineTransportOptions, Transport } from '@sentry/core';
import { makeOfflineTransport, parseEnvelope, serializeEnvelope } from '@sentry/core';
import { WINDOW } from '../helpers';
import { makeFetchTransport } from './fetch';

// 'Store', 'promisifyRequest' and 'createStore' were originally copied from the 'idb-keyval' package before being
Expand Down Expand Up @@ -158,7 +159,15 @@
function makeIndexedDbOfflineTransport<T>(
createTransport: (options: T) => Transport,
): (options: T & BrowserOfflineTransportOptions) => Transport {
return options => createTransport({ ...options, createStore: createIndexedDbStore });
return options => {
const transport = createTransport({ ...options, createStore: createIndexedDbStore });

WINDOW.addEventListener('online', async _ => {

Check failure on line 165 in packages/browser/src/transports/offline.ts

View workflow job for this annotation

GitHub Actions / Browser Unit Tests

test/transports/offline.test.ts > makeOfflineTransport > Queues and retries envelope if wrapped transport throws error

TypeError: WINDOW.addEventListener is not a function ❯ src/transports/offline.ts:165:12 ❯ test/transports/offline.test.ts:92:64
await transport.flush();
});

return transport;
};
}

/**
Expand Down
10 changes: 9 additions & 1 deletion packages/core/src/transports/offline.ts
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,15 @@ export function makeOfflineTransport<TO>(

return {
send,
flush: t => transport.flush(t),
flush: timeout => {
// If there's no timeout, we should attempt to flush the offline queue.
if (timeout === undefined) {
retryDelay = START_DELAY;
flushIn(MIN_DELAY);
}

return transport.flush(timeout);
},
};
};
}
Loading