Skip to content

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Dec 18, 2024

While investigating an internally reported SDK issue, I had the suspicion that our Node SDK might handle the sample rate from an incoming baggage header incorrectly. Turns out that's not the case and things work correctly. I couldn't find a test though, where we specifically cover a non 1.0 sentry-sample_rate baggage value, so I figured there's value in adding this test.

@Lms24 Lms24 requested a review from AbhiPrasad December 18, 2024 17:22
@Lms24 Lms24 self-assigned this Dec 18, 2024
@Lms24 Lms24 merged commit a2562e2 into develop Dec 19, 2024
38 checks passed
@Lms24 Lms24 deleted the lms/test-node-trace-propagation-sample_rate branch December 19, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants