ref(flags): copy empty flags to event for CTA #14945
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michellewzhang
approved these changes
Jan 8, 2025
michellewzhang
approved these changes
Jan 8, 2025
cmanallen
approved these changes
Jan 8, 2025
|
I don't think this is necessary as we are planning on adding a project flag on the backend which will be more reliable. This will also add unnecessary bytes to events. Given the backend feature and how long it will take to release a new SDK version and have users upgrade, I don't think it's worth changing this in the SDK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/getsentry/team-replay/issues/527
If
flagsis never initialized in the event context, sentry FE interprets this as not having set up a flag integration, and misleadingly shows a CTA.