fix(v8/sveltekit): Ensure source maps deletion is called after source maps upload #14963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ps upload (#14942) - replace the original release management plugin with a custom one where we start release creation on `closeBundle` - replace the original file deletion plugin with a custom one where we start deletion on `closeBundle` - in both cases, further ensuresthat the plugin is only invoked for build and as late as possible (`enforce: 'post'`). - searche for the release management plugin by its old and new name introduced in getsentry/sentry-javascript-bundler-plugins#647 - slightly rename the custom source maps uploading plugin for better convention; as well as some variables for better readability - add unit tests for the new custom sub plugins
Lms24
changed the title
s1gr1d
approved these changes
Jan 9, 2025
Lms24
changed the title
|
Argh I missed the commit message changing itself. Sorry to whoever is making the changelog 😬 |
This was referenced Jan 10, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #14942