Skip to content

Conversation

@davidturissini
Copy link
Contributor

Pulled the repository down locally and some tooling flagged an unused file in @sentry/sveltekit. It looks like this file is actually a test but was missing the .test.ts file extension. This PR adds the test extension.

Ran tests in @sentry/sveltekit and everything seems healthy.

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

@mydea mydea changed the title refactor(sveltekit): Removing unused file refactor(sveltekit): Remove unused file Jan 15, 2025
@mydea mydea changed the title refactor(sveltekit): Remove unused file ref(sveltekit): Remove unused file Jan 15, 2025
@mydea mydea requested a review from Lms24 January 15, 2025 08:11
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @davidturissini thanks for contributing! Great catch!

@Lms24 Lms24 merged commit c316f8b into getsentry:develop Jan 15, 2025
39 checks passed
mydea pushed a commit that referenced this pull request Jan 15, 2025
This PR adds the external contributor to the CHANGELOG.md file, so that
they are credited for their contribution. See #15020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants