Skip to content

ci(e2e-test): Switch to https://example.com from http equivalent for Next.js e2e tests #15052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 17, 2025
Merged

ci(e2e-test): Switch to https://example.com from http equivalent for Next.js e2e tests #15052

merged 3 commits into from
Jan 17, 2025

Conversation

@lforst
Copy link
Contributor

@lforst lforst commented Jan 17, 2025 •
edited
Loading

https seemed more reliable 🙃

@codecov
Copy link

codecov bot commented Jan 17, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
419 1 418 290
View the top 1 failed tests by shortest run time 
basic.test.ts AWS Serverless SDK sends events in ESM mode
Stack Traces | 2.2s run time 
basic.test.ts:5:5 AWS Serverless SDK sends events in ESM mode

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Luca Forstner added 2 commits January 17, 2025 13:30
@lforst lforst changed the title ci(e2e-test): Unparallelize nextjs-14 e2e tests ci(e2e-test): Switch to https://example.com from http equivalent for Next.js e2e tests Jan 17, 2025
@lforst lforst marked this pull request as ready for review January 17, 2025 13:52
@lforst lforst requested a review from Lms24 January 17, 2025 13:52
@lforst lforst merged commit e28d491 into develop Jan 17, 2025
147 checks passed
@lforst lforst deleted the lforst-maybee branch January 17, 2025 13:54
@Lms24 Lms24 mentioned this pull request Jan 17, 2025
Merged
Lms24 added a commit that referenced this pull request Jan 17, 2025
@Lms24
test(node): Use https version of example.com in Node integration tests (
e7446c5 
#15060)

Analogously to #15052
this PR switches to the https version of example.com since the http
version seems to have become unstable in the last couple of days. These
tests failed a lot in CI recently.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lms24 Lms24 Lms24 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lforst @Lms24