-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
chore(browser): Export ipAddress helpers for use in other SDKs #15079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report 📦
|
10 tasks
AbhiPrasad
reviewed
Jan 20, 2025
Member
AbhiPrasad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume we need to backport this to the v8 branch? develop is against v9 atm.
Contributor
Author
Member
Collaborator
|
I think these utilities would be more helpful in |
Contributor
Author
|
If #15008 is breaking change for JS, it's for RN as well, so we will adopt this with v9. |
…to kw-export-ip-address-helpers
Lms24
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
user.ip_addressexplicitly to{{auto}}#15008Export helpers to avoid duplications in sentry/react-native.
{{auto}}ifuser.ip_addressisundefinedandsendDefaultPii: truesentry-react-native#4466