Skip to content

fix(profiling-node): Add binary path to support @electron/rebuild #15112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

fix(profiling-node): Add binary path to support @electron/rebuild #15112

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
326832f
fix(profiling-node): Add binary path to support `@electron/rebuild`
timfish Jan 21, 2025
7e674f8
Move before non-electron paths
timfish Jan 21, 2025
ef338be
Add Electron check and warning
timfish Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/profiling-node/src/cpu_profiler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,18 @@ export function importCppBindingsModule(): PrivateV8CpuProfilerBindings {
return createdRequire(`${binaryPath}.node`);
}

if (process.versions.electron) {
try {
// @electron/rebuild generates the binary in the generic node-gyp directory
return createdRequire('../../build/Release/sentry_cpu_profiler.node');
} catch (_) {
// eslint-disable-next-line no-console
console.warn(
"Could not find '@sentry/profiling-node' binary. You should use '@electron/rebuild' to rebuild the native module.",
);
}
}

// We need the fallthrough so that in the end, we can fallback to the dynamic require.
// This is for cases where precompiled binaries were not provided, but may have been compiled from source.
if (platform === 'darwin') {
Expand Down
Loading