Skip to content

test(e2e): Fix flaky nextjs app router navigation transaction test #15158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AbhiPrasad wants to merge 1 commit into from
Closed

test(e2e): Fix flaky nextjs app router navigation transaction test #15158

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions ...e-tests/test-applications/nextjs-app-dir/tests/client-app-routing-instrumentation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,11 @@ test('Creates a navigation transaction for app router routes', async ({ page })
);
});

await page.goto(`/server-component/parameter/${randomRoute}`);
await clientPageloadTransactionPromise;
await page.getByText('Page (/server-component/[parameter])').isVisible();
await Promise.all([
page.goto(`/server-component/parameter/${randomRoute}`),
clientPageloadTransactionPromise,
page.getByText('Page (/server-component/[parameter])').isVisible(),
]);

const clientNavigationTransactionPromise = waitForTransaction('nextjs-app-dir', transactionEvent => {
return (
Expand All @@ -46,13 +48,17 @@ test('Creates a navigation transaction for app router routes', async ({ page })
);
});

await page.getByText('/server-component/parameter/foo/bar/baz').click();
const [, clientNavigationTransaction, serverComponentTransaction] = await Promise.all([
page.getByText('/server-component/parameter/foo/bar/baz').click(),
clientNavigationTransactionPromise,
serverComponentTransactionPromise,
]);

expect(await clientNavigationTransactionPromise).toBeDefined();
expect(await serverComponentTransactionPromise).toBeDefined();
expect(clientNavigationTransaction).toBeDefined();
expect(serverComponentTransaction).toBeDefined();

expect((await serverComponentTransactionPromise).contexts?.trace?.trace_id).toBe(
(await clientNavigationTransactionPromise).contexts?.trace?.trace_id,
expect(serverComponentTransaction.contexts?.trace?.trace_id).toBe(
clientNavigationTransaction.contexts?.trace?.trace_id,
);
});

Expand Down
Loading