Skip to content

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Feb 5, 2025

In v8, we published spotlightIntegration as part of the debugIntegration CDN integration bundle.

Since we removed debugIntegration in v9, the debug(.min).js bundle now only contains spotlightIntegration, which is confusing, and doesn't follow the usual naming patter for integration CDN bundles.

This PR therefore renames the bundle to spotlight(.min).js.

Note: For v9, we should remove the current debug integration docs

@Lms24 Lms24 self-assigned this Feb 5, 2025
@Lms24 Lms24 force-pushed the lms/feat-publish-spotlight-integraiton-cdn-bundle branch from ce381ac to 0e0e9e9 Compare February 5, 2025 11:08
@Lms24 Lms24 requested review from BYK and mydea February 5, 2025 11:10
Copy link

codecov bot commented Feb 5, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
630 1 629 300
View the full list of 1 ❄️ flaky tests
sdk.test.ts SDK-internal behaviorInjects fetch proxy script for SvelteKit<2.16.0

Flake rate in main: 35.29% (Passed 11 times, Failed 6 times)

Stack Traces | 0.15s run time
sdk.test.ts:4:3 Injects fetch proxy script for SvelteKit<2.16.0

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Copy link
Member

@BYK BYK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds and looks good, thanks!

@Lms24 Lms24 marked this pull request as ready for review February 5, 2025 13:13
@Lms24 Lms24 merged commit 215e1dc into develop Feb 5, 2025
114 of 116 checks passed
@Lms24 Lms24 deleted the lms/feat-publish-spotlight-integraiton-cdn-bundle branch February 5, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants