Skip to content

ci: Disable v8 compile cache functionality #15385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 12, 2025
Merged

ci: Disable v8 compile cache functionality #15385

merged 2 commits into from
Feb 12, 2025
+5 −0

Conversation

@lforst
Copy link
Contributor

@lforst lforst commented Feb 12, 2025

https://bsky.app/profile/joyeecheung.bsky.social/post/3lhy7xpe3ok2h

We are seeing failures coming from v8 and a node maintainer pointed us to the v8 compile cache packages creating a corrupted cache. Disabling should get rid of the failures.

@codecov
Copy link

codecov bot commented Feb 12, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
727 1 726 303
View the top 1 failed test(s) by shortest run time 
MongoDB experimental Test CJS - should auto-instrument `mongodb` package.
Stack Traces | 0.953s run time 
Error: expect(received).toMatchObject(expected)

- Expected  - 50
+ Received  + 92

@@ -1,61 +1,79 @@
  Object {
    "event_id": Any<String>,
    "spans": Array [
-     ObjectContaining {
+     Object {
        "data": Object {
-         "db.connection_string": Any<String>,
-         "db.mongodb.collection": "$cmd",
+         "db.connection_string": "mongodb://127.0.0.1:42857/admin",
+         "db.mongodb.collection": "movies",
          "db.name": "admin",
-         "db.operation": "isMaster",
-         "db.statement": "{\"ismaster\":\"?\",\"client\":{\"driver\":{\"name\":\"?\",\"version\":\"?\"},\"os\":{\"type\":\"?\",\"name\":\"?\",\"architecture\":\"?\",\"version\":\"?\"},\"platform\":\"?\"},\"compression\":[],\"helloOk\":\"?\"}",
+         "db.operation": "insert",
+         "db.statement": "{\"title\":\"?\",\"_id\":{\"_bsontype\":\"?\",\"id\":\"?\"}}",
          "db.system": "mongodb",
-         "net.peer.name": Any<String>,
-         "net.peer.port": Any<Number>,
+         "net.peer.name": "127.0.0.1",
+         "net.peer.port": 42857,
          "otel.kind": "CLIENT",
          "sentry.op": "db",
          "sentry.origin": "auto.db.otel.mongo",
        },
-       "description": "{\"ismaster\":\"?\",\"client\":{\"driver\":{\"name\":\"?\",\"version\":\"?\"},\"os\":{\"type\":\"?\",\"name\":\"?\",\"architecture\":\"?\",\"version\":\"?\"},\"platform\":\"?\"},\"compression\":[],\"helloOk\":\"?\"}",
+       "description": "{\"title\":\"?\",\"_id\":{\"_bsontype\":\"?\",\"id\":\"?\"}}",
        "op": "db",
        "origin": "auto.db.otel.mongo",
+       "parent_span_id": "56f0d61579d3abde",
+       "span_id": "adc123515aa2095e",
+       "start_timestamp": 1739365499.998,
+       "status": "ok",
+       "timestamp": 1739365500.00113,
+       "trace_id": "c4da9dd79dfc6c41fa13ab46278cc080",
      },
-     ObjectContaining {
+     Object {
        "data": Object {
-         "db.connection_string": Any<String>,
-         "db.mongodb.collection": "$cmd",
+         "db.connection_string": "mongodb://127.0.0.1:42857/admin",
+         "db.mongodb.collection": "movies",
          "db.name": "admin",
-         "db.operation": "isMaster",
-         "db.statement": "{\"ismaster\":\"?\",\"client\":{\"driver\":{\"name\":\"?\",\"version\":\"?\"},\"os\":{\"type\":\"?\",\"name\":\"?\",\"architecture\":\"?\",\"version\":\"?\"},\"platform\":\"?\"},\"compression\":[],\"helloOk\":\"?\"}",
+         "db.operation": "find",
+         "db.statement": "{\"title\":\"?\"}",
          "db.system": "mongodb",
-         "net.peer.name": Any<String>,
-         "net.peer.port": Any<Number>,
+         "net.peer.name": "127.0.0.1",
+         "net.peer.port": 42857,
          "otel.kind": "CLIENT",
          "sentry.op": "db",
          "sentry.origin": "auto.db.otel.mongo",
        },
-       "description": "{\"ismaster\":\"?\",\"client\":{\"driver\":{\"name\":\"?\",\"version\":\"?\"},\"os\":{\"type\":\"?\",\"name\":\"?\",\"architecture\":\"?\",\"version\":\"?\"},\"platform\":\"?\"},\"compression\":[],\"helloOk\":\"?\"}",
+       "description": "{\"title\":\"?\"}",
        "op": "db",
        "origin": "auto.db.otel.mongo",
+       "parent_span_id": "56f0d61579d3abde",
+       "span_id": "86daa3c1fe85d81d",
+       "start_timestamp": 1739365500.005,
+       "status": "ok",
+       "timestamp": 1739365500.0065818,
+       "trace_id": "c4da9dd79dfc6c41fa13ab46278cc080",
      },
-     ObjectContaining {
+     Object {
        "data": Object {
-         "db.connection_string": Any<String>,
+         "db.connection_string": "mongodb://127.0.0.1:42857/admin",
          "db.mongodb.collection": "movies",
          "db.name": "admin",
-         "db.operation": "insert",
-         "db.statement": "{\"title\":\"?\",\"_id\":{\"_bsontype\":\"?\",\"id\":\"?\"}}",
+         "db.operation": "update",
+         "db.statement": "{\"title\":\"?\"}",
          "db.system": "mongodb",
-         "net.peer.name": Any<String>,
-         "net.peer.port": Any<Number>,
+         "net.peer.name": "127.0.0.1",
+         "net.peer.port": 42857,
          "otel.kind": "CLIENT",
          "sentry.op": "db",
          "sentry.origin": "auto.db.otel.mongo",
        },
-       "description": "{\"title\":\"?\",\"_id\":{\"_bsontype\":\"?\",\"id\":\"?\"}}",
+       "description": "{\"title\":\"?\"}",
        "op": "db",
        "origin": "auto.db.otel.mongo",
+       "parent_span_id": "56f0d61579d3abde",
+       "span_id": "625f264df1f63078",
+       "start_timestamp": 1739365500.008,
+       "status": "ok",
+       "timestamp": 1739365500.0090094,
+       "trace_id": "c4da9dd79dfc6c41fa13ab46278cc080",
      },
      ObjectContaining {
        "data": Object {
          "db.connection_string": Any<String>,
          "db.mongodb.collection": "movies",
@@ -71,80 +89,104 @@
        },
        "description": "{\"title\":\"?\"}",
        "op": "db",
        "origin": "auto.db.otel.mongo",
      },
-     ObjectContaining {
+     Object {
        "data": Object {
-         "db.connection_string": Any<String>,
+         "db.connection_string": "mongodb://127.0.0.1:42857/admin",
          "db.mongodb.collection": "movies",
          "db.name": "admin",
-         "db.operation": "update",
+         "db.operation": "find",
          "db.statement": "{\"title\":\"?\"}",
          "db.system": "mongodb",
-         "net.peer.name": Any<String>,
-         "net.peer.port": Any<Number>,
+         "net.peer.name": "127.0.0.1",
+         "net.peer.port": 42857,
          "otel.kind": "CLIENT",
          "sentry.op": "db",
          "sentry.origin": "auto.db.otel.mongo",
        },
        "description": "{\"title\":\"?\"}",
        "op": "db",
        "origin": "auto.db.otel.mongo",
+       "parent_span_id": "56f0d61579d3abde",
+       "span_id": "c2486f0f9e14cbe7",
+       "start_timestamp": 1739365500.011,
+       "status": "ok",
+       "timestamp": 1739365500.011821,
+       "trace_id": "c4da9dd79dfc6c41fa13ab46278cc080",
      },
-     ObjectContaining {
+     Object {
        "data": Object {
-         "db.connection_string": Any<String>,
-         "db.mongodb.collection": "movies",
+         "db.connection_string": "mongodb://127.0.0.1:42857/admin",
+         "db.mongodb.collection": "$cmd",
          "db.name": "admin",
-         "db.operation": "find",
-         "db.statement": "{\"title\":\"?\"}",
+         "db.statement": "{\"endSessions\":[{\"id\":{\"_bsontype\":\"?\",\"sub_type\":\"?\",\"position\":\"?\",\"buffer\":\"?\"}}]}",
          "db.system": "mongodb",
-         "net.peer.name": Any<String>,
-         "net.peer.port": Any<Number>,
+         "net.peer.name": "127.0.0.1",
+         "net.peer.port": 42857,
          "otel.kind": "CLIENT",
          "sentry.op": "db",
          "sentry.origin": "auto.db.otel.mongo",
        },
-       "description": "{\"title\":\"?\"}",
+       "description": "{\"endSessions\":[{\"id\":{\"_bsontype\":\"?\",\"sub_type\":\"?\",\"position\":\"?\",\"buffer\":\"?\"}}]}",
        "op": "db",
        "origin": "auto.db.otel.mongo",
+       "parent_span_id": "56f0d61579d3abde",
+       "span_id": "d251437150322147",
+       "start_timestamp": 1739365500.014,
+       "status": "ok",
+       "timestamp": 1739365500.0147018,
+       "trace_id": "c4da9dd79dfc6c41fa13ab46278cc080",
      },
-     ObjectContaining {
+     Object {
        "data": Object {
-         "db.connection_string": Any<String>,
-         "db.mongodb.collection": "movies",
+         "db.connection_string": "mongodb://127.0.0.1:42857/admin",
+         "db.mongodb.collection": "$cmd",
          "db.name": "admin",
-         "db.operation": "find",
-         "db.statement": "{\"title\":\"?\"}",
+         "db.operation": "isMaster",
+         "db.statement": "{\"ismaster\":\"?\",\"client\":{\"driver\":{\"name\":\"?\",\"version\":\"?\"},\"os\":{\"type\":\"?\",\"name\":\"?\",\"architecture\":\"?\",\"version\":\"?\"},\"platform\":\"?\"},\"compression\":[],\"helloOk\":\"?\"}",
          "db.system": "mongodb",
-         "net.peer.name": Any<String>,
-         "net.peer.port": Any<Number>,
+         "net.peer.name": "127.0.0.1",
+         "net.peer.port": 42857,
          "otel.kind": "CLIENT",
          "sentry.op": "db",
          "sentry.origin": "auto.db.otel.mongo",
        },
-       "description": "{\"title\":\"?\"}",
+       "description": "{\"ismaster\":\"?\",\"client\":{\"driver\":{\"name\":\"?\",\"version\":\"?\"},\"os\":{\"type\":\"?\",\"name\":\"?\",\"architecture\":\"?\",\"version\":\"?\"},\"platform\":\"?\"},\"compression\":[],\"helloOk\":\"?\"}",
        "op": "db",
        "origin": "auto.db.otel.mongo",
+       "parent_span_id": "56f0d61579d3abde",
+       "span_id": "4a2e95ee7d2eb086",
+       "start_timestamp": 1739365499.97,
+       "status": "ok",
+       "timestamp": 1739365499.9875815,
+       "trace_id": "c4da9dd79dfc6c41fa13ab46278cc080",
      },
-     ObjectContaining {
+     Object {
        "data": Object {
-         "db.connection_string": Any<String>,
+         "db.connection_string": "mongodb://127.0.0.1:42857/admin",
          "db.mongodb.collection": "$cmd",
          "db.name": "admin",
-         "db.statement": "{\"endSessions\":[{\"id\":{\"_bsontype\":\"?\",\"sub_type\":\"?\",\"position\":\"?\",\"buffer\":\"?\"}}]}",
+         "db.operation": "isMaster",
+         "db.statement": "{\"ismaster\":\"?\",\"client\":{\"driver\":{\"name\":\"?\",\"version\":\"?\"},\"os\":{\"type\":\"?\",\"name\":\"?\",\"architecture\":\"?\",\"version\":\"?\"},\"platform\":\"?\"},\"compression\":[],\"helloOk\":\"?\"}",
          "db.system": "mongodb",
-         "net.peer.name": Any<String>,
-         "net.peer.port": Any<Number>,
+         "net.peer.name": "127.0.0.1",
+         "net.peer.port": 42857,
          "otel.kind": "CLIENT",
          "sentry.op": "db",
          "sentry.origin": "auto.db.otel.mongo",
        },
-       "description": "{\"endSessions\":[{\"id\":{\"_bsontype\":\"?\",\"sub_type\":\"?\",\"position\":\"?\",\"buffer\":\"?\"}}]}",
+       "description": "{\"ismaster\":\"?\",\"client\":{\"driver\":{\"name\":\"?\",\"version\":\"?\"},\"os\":{\"type\":\"?\",\"name\":\"?\",\"architecture\":\"?\",\"version\":\"?\"},\"platform\":\"?\"},\"compression\":[],\"helloOk\":\"?\"}",
        "op": "db",
        "origin": "auto.db.otel.mongo",
+       "parent_span_id": "56f0d61579d3abde",
+       "span_id": "1b228872ff0e25bf",
+       "start_timestamp": 1739365499.995,
+       "status": "ok",
+       "timestamp": 1739365499.9966297,
+       "trace_id": "c4da9dd79dfc6c41fa13ab46278cc080",
      },
    ],
    "start_timestamp": Anything,
    "timestamp": Anything,
    "transaction": "Test Transaction",
    at assertSentryTransaction (.../node-integration-tests/utils/assertions.ts:32:18)
    at expectTransactionEvent (.../node-integration-tests/utils/runner.ts:477:28)
    at newEnvelope (.../node-integration-tests/utils/runner.ts:281:15)
    at tryParseEnvelopeFromStdoutLine (.../node-integration-tests/utils/runner.ts:386:15)
    at Socket.<anonymous> (.../node-integration-tests/utils/runner.ts:404:15)
    at Socket.emit (node:events:517:28)
    at addChunk (node:internal/streams/readable:368:12)
    at readableAddChunk (node:internal/streams/readable:341:9)
    at Socket.Readable.push (node:internal/streams/readable:278:10)
    at Pipe.onStreamRead (node:internal/stream_base_commons:190:23)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@lforst lforst requested a review from Lms24 February 12, 2025 13:54
@lforst lforst merged commit 50942ce into develop Feb 12, 2025
55 checks passed
@lforst lforst deleted the lforst-no-v8-compile-cache branch February 12, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lms24 Lms24 Lms24 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lforst @Lms24