fix(nuxt): Ignore 300-400 status codes on app errors in Nuxt #15473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@s1gr1d apologies for the call out but I'm not sure how to get this reviewed. You seem to be the resident Nuxt expert at Sentry looking at previous PRs? |
lforst
changed the title
lforst
approved these changes
Feb 25, 2025
Comment on lines
+69
to
+71
| if (isNuxtError(error)) { | ||
| // Do not report if status code is 3xx or 4xx | ||
| if (error.statusCode >= 300 && error.statusCode < 500) { |
There was a problem hiding this comment.
The 2 conditions could be ANDed.
s1gr1d
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
This looks good to me. At first I thought this might not make sense as this is a client-only plugin and we would need to create an explicit server plugin (for Nuxt, not Nitro).
Nitro runs only in the server folder, but Nuxt also runs on the server when it does e.g. SSR.
However, I tested this and it seems like the errors from the Nuxt server side are passed to the client and the hook is called on the client as well. So this change is fine.
AbhiPrasad
pushed a commit
that referenced
this pull request
Feb 26, 2025
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See #15473 Co-authored-by: s1gr1d <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).Description
I noticed that Nuxt 300-400 status codes from the app are being reported to Sentry unnecessarily. There appears to be a guard against doing this on the server side errors but client side errors like 404 or 401s are being reported to Sentry.
I have simply added the same guard on the client side error reporter for the Nuxt integration of Sentry.