Skip to content

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Feb 25, 2025

Jest didn't like usages of import.meta.url but now we're using Vitest, these hacks can be removed.

Our Rollup config already converts this correctly when building our CommonJs output.

@codecov
Copy link

codecov bot commented Feb 25, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
4653 1 4652 330
View the full list of 1 ❄️ flaky tests
should report ANR when event loop blocked worker can be stopped and restarted

Flake rate in main: 4.35% (Passed 66 times, Failed 3 times)

Stack Traces | 15s run time
Error: thrown: "Exceeded timeout of 15000 ms for a test.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."
    at .../suites/anr/test.ts:204:3
    at _dispatchDescribe (.../jest-circus/build/index.js:98:26)
    at describe (.../jest-circus/build/index.js:60:5)
    at Object.<anonymous> (.../suites/anr/test.ts:109:1)
    at Runtime._execModule (.../jest-runtime/build/index.js:1646:24)
    at Runtime._loadModule (.../jest-runtime/build/index.js:1185:12)
    at Runtime.requireModule (.../jest-runtime/build/index.js:1009:12)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:13)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at runTestInternal (.../jest-runner/build/runTest.js:389:16)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@timfish timfish marked this pull request as ready for review February 25, 2025 15:10
Copy link
Contributor

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bless

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) February 25, 2025 15:41
@AbhiPrasad AbhiPrasad merged commit a6bf3e6 into develop Feb 25, 2025
147 of 149 checks passed
@AbhiPrasad AbhiPrasad deleted the timfish/test/node-import.meta.url-hacks branch February 25, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants