Skip to content

Conversation

AbhiPrasad
Copy link
Member

Ref #11084

@AbhiPrasad AbhiPrasad requested a review from a team February 25, 2025 18:18
@AbhiPrasad AbhiPrasad self-assigned this Feb 25, 2025
@AbhiPrasad AbhiPrasad requested review from lforst and removed request for a team February 25, 2025 18:18
@AbhiPrasad AbhiPrasad requested a review from a team as a code owner February 25, 2025 18:18
@AbhiPrasad AbhiPrasad requested a review from s1gr1d February 25, 2025 18:18
Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ez test refactor

@codecov
Copy link

codecov bot commented Feb 25, 2025

❌ 4 Tests Failed:

Tests completed Failed Passed Skipped
1869 4 1865 317
View the top 3 failed test(s) by shortest run time
src/core/sendFeedback.test.ts > src/core/sendFeedback.test.ts
Stack Traces | 0s run time
TypeError: Cannot read properties of undefined (reading 'TextEncoder')
 ❯ src/core/sendFeedback.test.ts:15:40
src/core/components/Actor.test.ts > Actor > renders the correct aria label for the button
Stack Traces | 0.000754s run time
ReferenceError: jest is not defined
 ❯ .../core/components/Actor.test.ts:30:28
src/core/getFeedback.test.ts > getFeedback > works with a client with Feedback
Stack Traces | 0.00859s run time
ReferenceError: jest is not definedsrc/core/getFeedback.test.ts:29:28

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) February 25, 2025 19:55
@AbhiPrasad AbhiPrasad merged commit fd6e405 into develop Feb 25, 2025
115 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-vitest-feedback branch February 25, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants