Skip to content

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Feb 25, 2025

ref #11084

Sorry for the huge PR, it was quite unavoidable! Vitest doesn't support the done callback that most Node integration tests used with Jest.

This PR:

  • Modifies all tests to:
    • Use Vitest imports
    • Use async rather than callback
  • Changes test runner and test server to be async
    • runner.start(done) becomes await runner.start().completed()
    • createTestServer() close function now throws any errors that occurred

@timfish timfish marked this pull request as ready for review February 25, 2025 22:36
@AbhiPrasad
Copy link
Member

Seems like vitest shaves off ~20 seconds from looking at CI and comparing locally as well.

@AbhiPrasad AbhiPrasad merged commit fda7103 into develop Feb 26, 2025
35 checks passed
@AbhiPrasad AbhiPrasad deleted the timfish/test/vitest-node-integration branch February 26, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants