Skip to content

perf(node): Remove normalizedRequest from scope after response is closed #15561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

perf(node): Remove normalizedRequest from scope after response is closed #15561

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f66175
perf(node): Remove `normalizedRequest` from scope after response is c…
AbhiPrasad Mar 3, 2025
6c6c146
switch to using finalization registry
AbhiPrasad Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/node/src/integrations/http/SentryHttpInstrumentation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,11 @@ export class SentryHttpInstrumentation extends InstrumentationBase<SentryHttpIns
// eslint-disable-next-line @typescript-eslint/no-this-alias
const instrumentation = this;

// @ts-expect-error: FinalizationRegistry is not yet in the Node types
const finalizationRegistry = new FinalizationRegistry((isolationScope: Scope) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to tryCatch this for legacy browsers?

isolationScope.setSDKProcessingMetadata({ normalizedRequest: undefined });
});

return (
original: (event: string, ...args: unknown[]) => boolean,
): ((this: unknown, event: string, ...args: unknown[]) => boolean) => {
Expand Down Expand Up @@ -183,6 +188,9 @@ export class SentryHttpInstrumentation extends InstrumentationBase<SentryHttpIns
});
}

// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
finalizationRegistry.register(response, isolationScope);

return withIsolationScope(isolationScope, () => {
return withScope(scope => {
// Set a new propagationSpanId for this request
Expand Down
Loading