fix(browser): Call original function on early return from patched history API #15576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This feels important enough we should add a regression test for, and maybe even think about backporting. |
|
This is a no-brainer to merge. We will follow up with regression tests. |
This was referenced Mar 5, 2025
chargome
added a commit
that referenced
this pull request
Mar 6, 2025
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See #15576 Co-authored-by: AbhiPrasad <[email protected]> Co-authored-by: Charly Gomez <[email protected]>
|
This broke our SPA badly. I suggest creating a 9.4.1 bugfix release for this. |
|
@adrianjost we have a release in progress - should be out tomorrow morning at the latest #15611 |
|
@adrianjost released with https://github.com/getsentry/sentry-javascript/releases/tag/9.5.0 - appreciate the patience in the meantime. |
|
Oh wow. Thank you so much for fixing this. I spent hours pulling my hair, trying to understand what was wrong, focusing on React Router as I thought it was the culprit 🤯 |
Zwyx
added a commit
to Zwyx/detrak
that referenced
this pull request
Mar 13, 2025
Sentry was preventing React Router's state from being synced with the browser. See getsentry/sentry-javascript#15576
Zwyx
added a commit
to Zwyx/detrak
that referenced
this pull request
Mar 13, 2025
Sentry was preventing React Router's state from being synced with the browser. See getsentry/sentry-javascript#15576
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #14696 an early
returnwas introduced that alters the default behavior of the underlying history API that is being patched.Instead of just returning, the original/underlying function should be called to keep the default behavior.