ref(core): Update log types to explicitly reference otel #15704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
Lms24 and
mydea
and removed request for
a team
AbhiPrasad
commented
Mar 17, 2025
| intValue: number; | ||
| // integers must be represented as a string | ||
| // because JSON cannot differentiate between integers and floats | ||
| intValue: string; |
Lms24
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #15530 I added types for the log envelope and log item.
This PR comes and explicitly references that these added types were otel logs. For more details, see the logs spec in develop: getsentry/sentry-docs#12920.
Note I used
Oteleverywhere here, but I'm also fine with switching toOpenTelemetry.