Skip to content

feat(nextjs): Disable server webpack-handling for static builds #15751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2025
Merged

feat(nextjs): Disable server webpack-handling for static builds #15751

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24caf4c
feat(nextjs): Disable server webpack-handling for static builds
s1gr1d Mar 20, 2025
28a5929
fix condition
s1gr1d Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/nextjs/src/config/webpack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,9 +341,11 @@ export function constructWebpackConfigFunction(
newConfig.entry = async () => addSentryToClientEntryProperty(origEntryProperty, buildContext);
}

// We don't want to do any webpack plugin stuff OR any source maps stuff in dev mode.
const isStaticExport = userNextConfig?.output === 'export';

// We don't want to do any webpack plugin stuff OR any source maps stuff in dev mode or for the server on static-only builds.
// Symbolication for dev-mode errors is done elsewhere.
if (!isDev) {
if (!isDev || !(isStaticExport && isServer)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (!isDev || !(isStaticExport && isServer)) {
if (!isDev && !(isStaticExport && isServer)) {

Only handle webpack when we're in prod AND we don't have a output: 'export' build

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it to !(isDev || (isStaticExport && isServer)) as it's easier to wrap the head around it (it contains two sides connected with OR and then everything is negated).

However, it's the same logical expression as !isDev && !(isStaticExport && isServer).

// eslint-disable-next-line @typescript-eslint/no-explicit-any
const { sentryWebpackPlugin } = loadModule<{ sentryWebpackPlugin: any }>('@sentry/webpack-plugin', module) ?? {};

Expand Down
Loading