Skip to content

profiling: add platform to chunk envelope #15758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 20, 2025
Merged

profiling: add platform to chunk envelope #15758

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
abe6ac0
profiling: add platform to envelope headers
JonasBa Mar 20, 2025
c277f67
profiling(node): add platform to profile_chunk envelope header
JonasBa Mar 20, 2025
aa056cd
profiling(node) rename platform to javascript.node
JonasBa Mar 20, 2025
7038c24
Revert "profiling(node) rename platform to javascript.node"
JonasBa Mar 20, 2025
146aa1c
profiling(node) obj shorthand
JonasBa Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/profiling-node/src/integration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,7 +516,7 @@ class ContinuousProfiler {
const metadata = this._client.getSdkMetadata();
const tunnel = this._client.getOptions().tunnel;

const envelope = makeProfileChunkEnvelope(chunk, metadata?.sdk, tunnel, dsn);
const envelope = makeProfileChunkEnvelope('node', chunk, metadata?.sdk, tunnel, dsn);
transport.send(envelope).then(null, reason => {
DEBUG_BUILD && logger.error('Error while sending profile chunk envelope:', reason);
});
Expand Down
2 changes: 2 additions & 0 deletions packages/profiling-node/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,13 +400,15 @@ export function createEventEnvelopeHeaders(
* Creates a standalone profile_chunk envelope.
*/
export function makeProfileChunkEnvelope(
platform: 'node',
chunk: ProfileChunk,
sdkInfo: SdkInfo | undefined,
tunnel: string | undefined,
dsn?: DsnComponents,
): ProfileChunkEnvelope {
const profileChunkHeader: ProfileChunkItem[0] = {
type: 'profile_chunk',
platform: platform,
};

return createEnvelope<ProfileChunkEnvelope>(createEventEnvelopeHeaders(sdkInfo, tunnel, dsn), [
Expand Down
4 changes: 3 additions & 1 deletion packages/profiling-node/test/integration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,7 +643,9 @@ describe('ProfilingIntegration', () => {
Sentry.profiler.stopProfiler();
vi.advanceTimersByTime(1000);

expect(transportSpy.mock.calls?.[0]?.[0]?.[1]?.[0]?.[0]?.type).toBe('profile_chunk');
const envelopeHeaders = transportSpy.mock.calls?.[0]?.[0]?.[1]?.[0]?.[0];
expect(envelopeHeaders?.type).toBe('profile_chunk');
expect(envelopeHeaders?.platform).toBe('node');
});

it('sets global profile context', async () => {
Expand Down