-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(react-router): Add sentryHandleRequest
#15787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
52525ed
add sentryHandleRequest
chargome 4ce7e38
update tests
chargome 6b02a88
Merge branch 'develop' into cg-rr-param-backend-tx
chargome b50b92d
Remove unnecessary code
4878e1c
Merge remote-tracking branch 'origin/develop' into cg-rr-param-backen…
5f0b8fa
Set source route
5f118af
log stuff
ae9a866
log some more
1dc8c35
.
20a55ea
fix deps
089feed
i am stomped
43aeb88
Merge remote-tracking branch 'origin/develop' into cg-rr-param-backen…
4ea05a5
holy shit I love this job sometimes why does software exist i will be…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
export const SENTRY_PARAMETERIZED_ROUTE = 'sentry.parameterized_route'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
export * from '@sentry/node'; | ||
|
||
export { init } from './sdk'; | ||
export { sentryHandleRequest } from './sentryHandleRequest'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
import type { AppLoadContext, EntryContext } from 'react-router'; | ||
import { SENTRY_PARAMETERIZED_ROUTE } from './attributes'; | ||
import { getRootSpan, getActiveSpan } from '@sentry/core'; | ||
|
||
type OriginalHandleRequest = ( | ||
request: Request, | ||
responseStatusCode: number, | ||
responseHeaders: Headers, | ||
routerContext: EntryContext, | ||
loadContext: AppLoadContext, | ||
) => Promise<unknown>; | ||
|
||
/** | ||
* Wraps the original handleRequest function to add Sentry instrumentation. | ||
* | ||
* @param originalHandle - The original handleRequest function to wrap | ||
* @returns A wrapped version of the handle request function with Sentry instrumentation | ||
*/ | ||
export function sentryHandleRequest(originalHandle: OriginalHandleRequest): OriginalHandleRequest { | ||
return async function sentryInstrumentedHandleRequest( | ||
request: Request, | ||
responseStatusCode: number, | ||
responseHeaders: Headers, | ||
routerContext: EntryContext, | ||
loadContext: AppLoadContext, | ||
) { | ||
const parameterizedPath = | ||
routerContext?.staticHandlerContext?.matches?.[routerContext.staticHandlerContext.matches.length - 1]?.route.path; | ||
if (parameterizedPath) { | ||
const activeSpan = getActiveSpan(); | ||
if (activeSpan) { | ||
const rootSpan = getRootSpan(activeSpan); | ||
rootSpan.setAttribute(SENTRY_PARAMETERIZED_ROUTE, parameterizedPath); | ||
} | ||
} | ||
return originalHandle(request, responseStatusCode, responseHeaders, routerContext, loadContext); | ||
}; | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we don't update the name of the root span here directly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this, but it got overwritten somehow