Skip to content

Conversation

@s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Apr 14, 2025

Logging the tracing meta tags makes debugging things like this easier.

@s1gr1d s1gr1d requested review from Lms24, lforst and mydea April 14, 2025 11:38
Comment on lines 42 to 45
consoleSandbox(() => {
// eslint-disable-next-line no-console
console.log('[Sentry] Adding Sentry tracing meta tags to HTML page:', metaTags);
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m: can we use logger instead? then we don't need to worry about the sandbox

@s1gr1d s1gr1d requested a review from Lms24 April 14, 2025 12:21
Comment on lines 41 to 43
if (debug) {
logger.log('Adding Sentry tracing meta tags to HTML page:', metaTags);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: I think I caused this confusion in our offline convo: We don't even need the debug flag check here because the logger won't emit anything unless people init the SDK with debug: true.

@s1gr1d s1gr1d merged commit 5cd3457 into develop Apr 17, 2025
152 checks passed
@s1gr1d s1gr1d deleted the sig/html-injection-debug branch April 17, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants