-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
meta(changelog): Update changelog for 9.14.0 #16115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 19 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
8682df0
test(node): Increase timeout of anr tests (#16076)
mydea 056a865
ci: Fix issue labelling with multiple labels (#16072)
mydea 9f9a6c1
ci: Finally really fix issue labels (#16080)
mydea e066a4b
ci: Finally fix it for real real (#16082)
mydea 4e82018
Merge pull request #16083 from getsentry/master
github-actions[bot] 3bc1923
ci: Fix additional label (#16085)
mydea f1b8291
build(deps): Bump astro from 4.16.1 to 4.16.18 in /dev-packages/e2e-t…
dependabot[bot] 87e5f8b
test(nuxt): Add tests for trace baggage (#16046)
s1gr1d 263eeee
feat: Add Supabase Integration (#15719)
onurtemizkan 5cd3457
feat(nuxt): Log when adding HTML trace meta tags (#16044)
s1gr1d e4f4597
feat(react-router): Trace propagation (#16070)
chargome 1d10238
ref(node): Log when incoming request bodies are being captured (#16104)
mydea 8026b85
build(deps): Bump fastify from 5.0.0 to 5.3.2 in /dev-packages/e2e-te…
dependabot[bot] 447e62e
feat(deps): Bump @prisma/instrumentation from 6.5.0 to 6.6.0 (#16102)
dependabot[bot] 88ba26b
fix(node): Make body capturing more robust (#16105)
a3d0224
ref(core): Remove internal `utils-hoist` re-export (#16114)
mydea 7438608
feat(nextjs): Improve server component data (#15996)
20ce849
feat(nestjs): Gracefully handle RPC scenarios in `SentryGlobalFilter`…
chargome 749eda9
meta(changelog): Update changelog for 9.14.0
chargome 7c0365c
rm ref pr
chargome File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44,7 +44,7 @@ jobs: | |
"@sentry.bun": { | ||
"label": "Bun" | ||
}, | ||
"@sentry.cloudflare - hono": { | ||
"@sentry.cloudflare.-.hono": { | ||
"label": "Hono" | ||
}, | ||
"@sentry.cloudflare": { | ||
|
@@ -68,20 +68,20 @@ jobs: | |
"@sentry.nextjs": { | ||
"label": "Next.js" | ||
}, | ||
"@sentry.node - express": { | ||
"@sentry.node.-.express": { | ||
"label": "Express" | ||
}, | ||
"@sentry.node - fastify": { | ||
"@sentry.node.-.fastify": { | ||
"label": "Fastify" | ||
}, | ||
"@sentry.node - koa": { | ||
"@sentry.node.-.koa": { | ||
"label": "Koa" | ||
}, | ||
"@sentry.node - hapi": { | ||
"label": "Hapi | ||
"@sentry.node.-.hapi": { | ||
"label": "Hapi" | ||
}, | ||
"@sentry.node - connect": { | ||
"label": "Connect | ||
"@sentry.node.-.connect": { | ||
"label": "Connect" | ||
}, | ||
"@sentry.node": { | ||
"label": "Node.js" | ||
|
@@ -90,7 +90,7 @@ jobs: | |
"label": "Nuxt" | ||
}, | ||
"@sentry.react-router": { | ||
"label": "React Router Framework " | ||
"label": "React Router Framework" | ||
}, | ||
"@sentry.react": { | ||
"label": "React" | ||
|
@@ -120,10 +120,10 @@ jobs: | |
"label": "WASM" | ||
}, | ||
"Sentry.Browser.Loader": { | ||
"label": "Browser\nLoader Script" | ||
"label": "Browser" | ||
}, | ||
"Sentry.Browser.CDN.bundle": { | ||
"label": "Browser\nCDN Bundle" | ||
"label": "Browser" | ||
} | ||
} | ||
export_to: output | ||
|
@@ -134,3 +134,29 @@ jobs: | |
uses: actions-ecosystem/action-add-labels@v1 | ||
with: | ||
labels: ${{ steps.packageLabel.outputs.label }} | ||
|
||
- name: Map additional to issue label | ||
# https://github.com/kanga333/variable-mapper | ||
uses: kanga333/[email protected] | ||
id: additionalLabel | ||
if: steps.packageName.outputs.match != '' | ||
with: | ||
key: '${{ steps.packageName.outputs.group1 }}' | ||
# Note: Since this is handled as a regex, and JSON parse wrangles slashes /, we just use `.` instead | ||
map: | | ||
{ | ||
"Sentry.Browser.Loader": { | ||
"label": "Loader Script" | ||
}, | ||
"Sentry.Browser.CDN.bundle": { | ||
"label": "CDN Bundle" | ||
} | ||
} | ||
export_to: output | ||
|
||
- name: Add additional label if applicable | ||
# Note: We only add the label if the issue is still open | ||
if: steps.additionalLabel.outputs.label != '' | ||
uses: actions-ecosystem/action-add-labels@v1 | ||
with: | ||
labels: ${{ steps.additionalLabel.outputs.label }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 24 additions & 0 deletions
24
dev-packages/browser-integration-tests/suites/integrations/supabase/auth/init.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
import * as Sentry from '@sentry/browser'; | ||
|
||
import { createClient } from '@supabase/supabase-js'; | ||
window.Sentry = Sentry; | ||
|
||
const supabaseClient = createClient('https://test.supabase.co', 'test-key'); | ||
|
||
Sentry.init({ | ||
dsn: 'https://[email protected]/1337', | ||
integrations: [Sentry.browserTracingIntegration(), Sentry.supabaseIntegration({ supabaseClient })], | ||
tracesSampleRate: 1.0, | ||
}); | ||
|
||
// Simulate authentication operations | ||
async function performAuthenticationOperations() { | ||
await supabaseClient.auth.signInWithPassword({ | ||
email: '[email protected]', | ||
password: 'test-password', | ||
}); | ||
|
||
await supabaseClient.auth.signOut(); | ||
} | ||
|
||
performAuthenticationOperations(); |
147 changes: 147 additions & 0 deletions
147
dev-packages/browser-integration-tests/suites/integrations/supabase/auth/test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,147 @@ | ||
import type { Page } from '@playwright/test'; | ||
import { expect } from '@playwright/test'; | ||
import type { Event } from '@sentry/core'; | ||
|
||
import { sentryTest } from '../../../../utils/fixtures'; | ||
import { | ||
getFirstSentryEnvelopeRequest, | ||
getMultipleSentryEnvelopeRequests, | ||
shouldSkipTracingTest, | ||
} from '../../../../utils/helpers'; | ||
|
||
async function mockSupabaseAuthRoutesSuccess(page: Page) { | ||
await page.route('**/auth/v1/token?grant_type=password**', route => { | ||
return route.fulfill({ | ||
status: 200, | ||
body: JSON.stringify({ | ||
access_token: 'test-access-token', | ||
refresh_token: 'test-refresh-token', | ||
token_type: 'bearer', | ||
expires_in: 3600, | ||
}), | ||
headers: { | ||
'Content-Type': 'application/json', | ||
}, | ||
}); | ||
}); | ||
|
||
await page.route('**/auth/v1/logout**', route => { | ||
return route.fulfill({ | ||
status: 200, | ||
body: JSON.stringify({ | ||
message: 'Logged out', | ||
}), | ||
headers: { | ||
'Content-Type': 'application/json', | ||
}, | ||
}); | ||
}); | ||
} | ||
|
||
async function mockSupabaseAuthRoutesFailure(page: Page) { | ||
await page.route('**/auth/v1/token?grant_type=password**', route => { | ||
return route.fulfill({ | ||
status: 400, | ||
body: JSON.stringify({ | ||
error_description: 'Invalid email or password', | ||
error: 'invalid_grant', | ||
}), | ||
headers: { | ||
'Content-Type': 'application/json', | ||
}, | ||
}); | ||
}); | ||
|
||
await page.route('**/auth/v1/logout**', route => { | ||
return route.fulfill({ | ||
status: 400, | ||
body: JSON.stringify({ | ||
error_description: 'Invalid refresh token', | ||
error: 'invalid_grant', | ||
}), | ||
headers: { | ||
'Content-Type': 'application/json', | ||
}, | ||
}); | ||
}); | ||
} | ||
|
||
|
||
const bundle = process.env.PW_BUNDLE || ''; | ||
// We only want to run this in non-CDN bundle mode | ||
if (bundle.startsWith('bundle')) { | ||
sentryTest.skip(); | ||
} | ||
|
||
sentryTest('should capture Supabase authentication spans', async ({ getLocalTestUrl, page }) => { | ||
if (shouldSkipTracingTest()) { | ||
return; | ||
} | ||
|
||
await mockSupabaseAuthRoutesSuccess(page); | ||
|
||
const url = await getLocalTestUrl({ testDir: __dirname }); | ||
|
||
const eventData = await getFirstSentryEnvelopeRequest<Event>(page, url); | ||
const supabaseSpans = eventData.spans?.filter(({ op }) => op?.startsWith('db.auth')); | ||
|
||
expect(supabaseSpans).toHaveLength(2); | ||
expect(supabaseSpans![0]).toMatchObject({ | ||
description: 'signInWithPassword', | ||
parent_span_id: eventData.contexts?.trace?.span_id, | ||
span_id: expect.any(String), | ||
start_timestamp: expect.any(Number), | ||
timestamp: expect.any(Number), | ||
trace_id: eventData.contexts?.trace?.trace_id, | ||
status: 'ok', | ||
data: expect.objectContaining({ | ||
'sentry.op': 'db.auth.signInWithPassword', | ||
'sentry.origin': 'auto.db.supabase', | ||
}), | ||
}); | ||
|
||
expect(supabaseSpans![1]).toMatchObject({ | ||
description: 'signOut', | ||
parent_span_id: eventData.contexts?.trace?.span_id, | ||
span_id: expect.any(String), | ||
start_timestamp: expect.any(Number), | ||
timestamp: expect.any(Number), | ||
trace_id: eventData.contexts?.trace?.trace_id, | ||
status: 'ok', | ||
data: expect.objectContaining({ | ||
'sentry.op': 'db.auth.signOut', | ||
'sentry.origin': 'auto.db.supabase', | ||
}), | ||
}); | ||
}); | ||
|
||
sentryTest('should capture Supabase authentication errors', async ({ getLocalTestUrl, page }) => { | ||
if (shouldSkipTracingTest()) { | ||
return; | ||
} | ||
|
||
await mockSupabaseAuthRoutesFailure(page); | ||
|
||
const url = await getLocalTestUrl({ testDir: __dirname }); | ||
|
||
const [errorEvent, transactionEvent] = await getMultipleSentryEnvelopeRequests<Event>(page, 2, { url }); | ||
|
||
const supabaseSpans = transactionEvent.spans?.filter(({ op }) => op?.startsWith('db.auth')); | ||
|
||
expect(errorEvent.exception?.values?.[0].value).toBe('Invalid email or password'); | ||
|
||
expect(supabaseSpans).toHaveLength(2); | ||
expect(supabaseSpans![0]).toMatchObject({ | ||
description: 'signInWithPassword', | ||
parent_span_id: transactionEvent.contexts?.trace?.span_id, | ||
span_id: expect.any(String), | ||
start_timestamp: expect.any(Number), | ||
timestamp: expect.any(Number), | ||
trace_id: transactionEvent.contexts?.trace?.trace_id, | ||
status: 'unknown_error', | ||
data: expect.objectContaining({ | ||
'sentry.op': 'db.auth.signInWithPassword', | ||
'sentry.origin': 'auto.db.supabase', | ||
}), | ||
}); | ||
}); |
28 changes: 28 additions & 0 deletions
28
dev-packages/browser-integration-tests/suites/integrations/supabase/db-operations/init.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
import * as Sentry from '@sentry/browser'; | ||
|
||
import { createClient } from '@supabase/supabase-js'; | ||
window.Sentry = Sentry; | ||
|
||
const supabaseClient = createClient('https://test.supabase.co', 'test-key'); | ||
|
||
Sentry.init({ | ||
dsn: 'https://[email protected]/1337', | ||
integrations: [Sentry.browserTracingIntegration(), Sentry.supabaseIntegration({ supabaseClient })], | ||
tracesSampleRate: 1.0, | ||
}); | ||
|
||
// Simulate database operations | ||
async function performDatabaseOperations() { | ||
try { | ||
await supabaseClient.from('todos').insert([{ title: 'Test Todo' }]); | ||
|
||
await supabaseClient.from('todos').select('*'); | ||
|
||
// Trigger an error to capture the breadcrumbs | ||
throw new Error('Test Error'); | ||
} catch (error) { | ||
Sentry.captureException(error); | ||
} | ||
} | ||
|
||
performDatabaseOperations(); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.