Skip to content

fix(remix): Add ESM-compatible exports #16124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 25, 2025
Merged

fix(remix): Add ESM-compatible exports #16124

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d23532c
fix(remix): Add ESM-compatible exports
s1gr1d Apr 24, 2025
76b2469
set default to cjs
s1gr1d Apr 24, 2025
1383761
change default to server import
s1gr1d Apr 24, 2025
130cbd9
remove default
s1gr1d Apr 24, 2025
826ae7b
Try setting `worker` entry
onurtemizkan Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/remix/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,14 @@
"types": "./build/types/index.types.d.ts",
"browser": {
"import": "./build/esm/index.client.js",
"require": "./build/cjs/index.client.js"
"require": "./build/cjs/index.client.js",
"default": "./build/cjs/index.client.js"
},
"node": "./build/cjs/index.server.js"
"node": {
"import": "./build/esm/index.server.js",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering if this import entry here is the reason for the failing tests 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you think that? I am not sure myself - it should theoretically work like this and all our other Meta-Framework packages handle the exports like this.

Copy link
Member

@Lms24 Lms24 Apr 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just because in SvelteKit we still use node: "./build/cjs/index.server.js" and it's still compatible with vite 6. So we don't point to the actual ESM code but to CJS (kit isn't the best example in terms of instrumentation compatibility but I'm not sure if remix is any better tbh)

ReferenceError: module is not defined in ES module scope

this suggested to me that we're using the wrong entry point somewhere, so I compared it to svetelkit. But not sure tbh, this could be a completely wrong idea too

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What seems to work is to set a new "worker" entry, and point it to our cloudflare build entries (similar to SvelteKit SDK).

"require": "./build/cjs/index.server.js",
"default": "./build/cjs/index.server.js"
}
},
"./cloudflare": {
"import": "./build/esm/cloudflare/index.js",
Expand Down
Loading