Skip to content

Conversation

RulaKhaled
Copy link
Member

@RulaKhaled RulaKhaled commented May 7, 2025

Filter out server side noisy transactions triggered by http integration from react-router. Fixes: #16161

@RulaKhaled RulaKhaled requested a review from chargome May 7, 2025 15:17
Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!
Not sure, something to look at in a follow up, but does the logic we have for nuxt make sense where we ignore all requests to files with ending (e.g. GET asdasd.png)? 🤔 but this is something to iterate on :)

Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🥇

@chargome
Copy link
Member

chargome commented May 8, 2025

Not sure, something to look at in a follow up, but does the logic we have for nuxt make sense where we ignore all requests to files with ending (e.g. GET asdasd.png)?

@mydea good point but we need to make sure not to filter e.g. /some/route.data as we depend on that atm 👍

@RulaKhaled RulaKhaled merged commit 558d3ff into develop May 12, 2025
29 checks passed
@RulaKhaled RulaKhaled deleted the create-lowQualityTransactionsFilter-for-react-router branch May 12, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RR7] Add server-side transaction noise filter

4 participants