Skip to content

Conversation

@AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad requested a review from a team May 28, 2025 00:16
@AbhiPrasad AbhiPrasad self-assigned this May 28, 2025
@AbhiPrasad AbhiPrasad requested review from Lms24 and mydea and removed request for a team May 28, 2025 00:16
* @param currentScope - The current scope.
* @returns The scope data.
*/
function getScopeData(currentScope: Scope): ScopeData {
Copy link
Member

@Lms24 Lms24 May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l/also fine as follow-up: Wdyt about making this a utility function? We have very similar logic in our event processing pipeline

const data = getGlobalScope().getScopeData();
if (isolationScope) {
const isolationData = isolationScope.getScopeData();
mergeScopeData(data, isolationData);
}
if (finalScope) {
const finalScopeData = finalScope.getScopeData();
mergeScopeData(data, finalScopeData);
}

as well as in Node ANR (though admittedly I don't care much about the bundle size there)

might save some bytes and it might help us get rid of the complexity eslint comment (though again, low prio obviously)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also can we rename this to e.g. getMergedScopeData() or something like this, was not clear to me from the function name that this would consider isolation scope etc :)

@AbhiPrasad
Copy link
Member Author

Will think about the utility function as a follow up

@AbhiPrasad AbhiPrasad force-pushed the abhi-user-on-logs branch from 031af1c to 4f6f301 Compare May 29, 2025 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants