test(e2e): Add tsx + express e2e test app
#16578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
requested review from
mydea,
a team and
AbhiPrasad
and removed request for
a team
|
hmm, local variables seem to not work, at least the test is failing? 🤔 |
|
woah completely forgot that this still exists. Re-running the tests for now. If localvariables still don't work, I think this is likely a limitation of |
|
Update:
|
Lms24
requested review from
a team,
chargome and
RulaKhaled
and removed request for
a team
RulaKhaled
pushed a commit
that referenced
this pull request
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In light of #16575, this PR adds an e2e test app for running an express app via
tsxinstead of transpiling it and running it with node directly. I basically just copied the app and tests from ournode-expresse2e app, so it also contains tests for TRPC and MCP stuff. If reviewers prefer, I can remove the additional stuff but I think it actually makes sense to test a "loaded" express app with additional instrumentation.Importantly, I had to
--importthe instrument file because TSX seems to internally transpile to ESM by default.