Skip to content

Conversation

@AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Jun 17, 2025

This refactor helps clean up redundant code.

ref #16580 (comment)

@AbhiPrasad AbhiPrasad requested review from a team and mydea June 17, 2025 15:47
@AbhiPrasad AbhiPrasad self-assigned this Jun 17, 2025
@AbhiPrasad AbhiPrasad requested review from RulaKhaled and removed request for a team June 17, 2025 15:47
@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.99 kB - -
@sentry/browser - with treeshaking flags 23.76 kB - -
@sentry/browser (incl. Tracing) 38.79 kB - -
@sentry/browser (incl. Tracing, Replay) 76.92 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 70 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 81.68 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 93.75 kB - -
@sentry/browser (incl. Feedback) 40.73 kB - -
@sentry/browser (incl. sendFeedback) 28.7 kB - -
@sentry/browser (incl. FeedbackAsync) 33.59 kB - -
@sentry/react 25.76 kB - -
@sentry/react (incl. Tracing) 40.78 kB - -
@sentry/vue 28.36 kB - -
@sentry/vue (incl. Tracing) 40.66 kB - -
@sentry/svelte 24.01 kB - -
CDN Bundle 25.48 kB - -
CDN Bundle (incl. Tracing) 38.96 kB - -
CDN Bundle (incl. Tracing, Replay) 74.81 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 80.23 kB - -
CDN Bundle - uncompressed 74.48 kB - -
CDN Bundle (incl. Tracing) - uncompressed 115.3 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 229.35 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 242.18 kB - -
@sentry/nextjs (client) 42.44 kB - -
@sentry/sveltekit (client) 39.28 kB - -
@sentry/node 150.72 kB -0.03% -37 B 🔽
@sentry/node - without tracing 98.52 kB - -
@sentry/aws-serverless 124.27 kB -0.01% -1 B 🔽

View base workflow run

@codecov
Copy link

codecov bot commented Jun 17, 2025

❌ Unsupported file format

Upload processing failed due to unsupported file format. Please review the parser error message:

Error parsing JUnit XML in /home/runner/work/sentry-javascript/sentry-javascript/packages/solidstart/vitest.junit.xml at 67:20

Caused by:
    RuntimeError: Error parsing XML
    
    Caused by:
        0: ill-formed document: expected `</testsuites>`, but `</testcase>` was found
        1: expected `</testsuites>`, but `</testcase>` was found

For more help, visit our troubleshooting guide.

@AbhiPrasad AbhiPrasad merged commit a34ad66 into develop Jun 18, 2025
325 of 327 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-rename-attribute-helper branch June 18, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants