-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(pino): Add initial package for @sentry/pino-transport
#16652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4a9fa6d to
b1a4a5c
Compare
andreiborza
approved these changes
Jun 20, 2025
packages/pino-transport/package.json
Outdated
| }, | ||
| "dependencies": { | ||
| "@sentry/core": "9.30.0", | ||
| "@sentry/node": "9.30.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
q: Should the node sdk be a dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it shouldn't - we can remove!
b1a4a5c to
34b3642
Compare
andreiborza
approved these changes
Jun 20, 2025
This was referenced Sep 29, 2025
This was referenced Oct 7, 2025
andreiborza
pushed a commit
to thedanchez/sentry-javascript
that referenced
this pull request
Oct 15, 2025
This package was added in getsentry#16652, but with the merge of getsentry#17584 we can remove it. We will recommend users use the `pinoIntegration` because it's way easier to set up and tracing works ootb. This package was never published (no craft config) so it's safe to remove.
This was referenced Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #15952
resolves #16621
We've gotten a lot of feedback about supporting pino. This PR kicks that off by creating a new pino package, specifically for the pino transport.
All pino transports need to use https://github.com/pinojs/pino-abstract-transport, which we don't want to add as a dep to
@sentry/node. Hopefully keeping the versions in sync shouldn't be too bad, although I'll force a peer dep range.