Skip to content

fix(nuxt): Only add OTel alias in dev mode #16756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2025
Merged

fix(nuxt): Only add OTel alias in dev mode #16756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b38e89f
fix(nuxt): Only add OTel alias in dev mode
s1gr1d Jun 27, 2025
de91821
fix conditional
s1gr1d Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/nuxt/src/vite/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,9 +191,15 @@ export function constructFunctionReExport(pathWithQuery: string, entryId: string
* @see https://nuxt.com/docs/guide/concepts/esm#aliasing-libraries
*/
export function addOTelCommonJSImportAlias(nuxt: Nuxt): void {
if (!nuxt.options.dev) {
return;
}

if (!nuxt.options.alias) {
nuxt.options.alias = {};
}

nuxt.options.alias['@opentelemetry/resources'] = '@opentelemetry/resources/build/src/index.js';
if (!nuxt.options.alias['@opentelemetry/resources']) {
nuxt.options.alias['@opentelemetry/resources'] = '@opentelemetry/resources/build/src/index.js';
}
}
18 changes: 15 additions & 3 deletions packages/nuxt/test/vite/utils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@ export { foo_sentryWrapped as foo };
describe('addOTelCommonJSImportAlias', () => {
it('adds alias for @opentelemetry/resources when options.alias does not exist', () => {
const nuxtMock: Nuxt = {
options: {},
options: { dev: true },
} as unknown as Nuxt;

addOTelCommonJSImportAlias(nuxtMock);
Expand All @@ -384,6 +384,7 @@ describe('addOTelCommonJSImportAlias', () => {
it('adds alias for @opentelemetry/resources when options.alias already exists', () => {
const nuxtMock: Nuxt = {
options: {
dev: true,
alias: {
'existing-alias': 'some-path',
},
Expand All @@ -398,9 +399,10 @@ describe('addOTelCommonJSImportAlias', () => {
});
});

it('overwrites existing alias for @opentelemetry/resources if already present', () => {
it('does not override existing alias for @opentelemetry/resources', () => {
const nuxtMock: Nuxt = {
options: {
dev: true,
alias: {
'@opentelemetry/resources': 'some-other-path',
},
Expand All @@ -410,7 +412,17 @@ describe('addOTelCommonJSImportAlias', () => {
addOTelCommonJSImportAlias(nuxtMock);

expect(nuxtMock.options.alias).toEqual({
'@opentelemetry/resources': '@opentelemetry/resources/build/src/index.js',
'@opentelemetry/resources': 'some-other-path',
});
});

it('does not add alias when not development mode', () => {
const nuxtMock: Nuxt = {
options: {},
} as unknown as Nuxt;

addOTelCommonJSImportAlias(nuxtMock);

expect(nuxtMock.options.alias).toBeUndefined();
});
});
Loading