Skip to content

fix(cloudflare): calculate retries not attempts #16834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2025
Merged

fix(cloudflare): calculate retries not attempts #16834

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c089b0
Calculate retries not attempts
stayallive Jul 7, 2025
6279088
CS
stayallive Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cloudflare/src/handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ export function withSentry<Env = unknown, QueueHandlerMessage = unknown, CfHostM
'messaging.destination.name': batch.queue,
'messaging.system': 'cloudflare',
'messaging.batch.message_count': batch.messages.length,
'messaging.message.retry.count': batch.messages.reduce((acc, message) => acc + message.attempts, 0),
'messaging.message.retry.count': batch.messages.reduce((acc, message) => acc + message.attempts - 1, 0),
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'queue.process',
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.faas.cloudflare.queue',
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'task',
Expand Down
2 changes: 1 addition & 1 deletion packages/cloudflare/test/handler.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -843,7 +843,7 @@ describe('withSentry', () => {
'messaging.destination.name': batch.queue,
'messaging.system': 'cloudflare',
'messaging.batch.message_count': batch.messages.length,
'messaging.message.retry.count': batch.messages.reduce((acc, message) => acc + message.attempts, 0),
'messaging.message.retry.count': batch.messages.reduce((acc, message) => acc + message.attempts - 1, 0),
'sentry.sample_rate': 1,
'sentry.source': 'task',
},
Expand Down
Loading