Skip to content

feat(node): Drop 401-404 and 3xx status code spans by default #16972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 15, 2025
Merged

feat(node): Drop 401-404 and 3xx status code spans by default #16972

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d5c827a
feat(node): Drop 3xx status code spans by default
mydea Jul 14, 2025
7135d8f
Remove redirect test from nexctjs-14, remove redirect events from remix
andreiborza Jul 14, 2025
f7498ce
Widen drop `http.server` spans to 401-404
andreiborza Jul 14, 2025
072ca80
Adjust e2e tests
andreiborza Jul 14, 2025
4c8ffbe
Add integration tests covering 401, 402, 403 filtering
andreiborza Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/node/src/integrations/http/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ interface HttpOptions {
* By default, spans with 404 status code are ignored.
* Expects an array of status codes or a range of status codes, e.g. [[300,399], 404] would ignore 3xx and 404 status codes.
*
* @default `[404]`
* @default `[404, [300, 399]]`
*/
dropSpansForIncomingRequestStatusCodes?: (number | [number, number])[];

Expand Down Expand Up @@ -184,7 +184,7 @@ export function _shouldInstrumentSpans(options: HttpOptions, clientOptions: Part
* It creates breadcrumbs and spans for outgoing HTTP requests which will be attached to the currently active span.
*/
export const httpIntegration = defineIntegration((options: HttpOptions = {}) => {
const dropSpansForIncomingRequestStatusCodes = options.dropSpansForIncomingRequestStatusCodes ?? [404];
const dropSpansForIncomingRequestStatusCodes = options.dropSpansForIncomingRequestStatusCodes ?? [404, [300, 399]];

return {
name: INTEGRATION_NAME,
Expand Down
Loading