feat(core)!: Remove logger and type Logger
#17073
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`logger` and type `Logger` were deprecated in v9, use `debug` and type `SentryDebugLogger` instead.
andreiborza
commented
Jul 17, 2025
| /** @deprecated Logger is no longer set. Instead, we keep enabled state in loggerSettings. */ | ||
| // eslint-disable-next-line deprecation/deprecation | ||
| logger?: Logger; | ||
| logger?: SentryDebugLogger; |
There was a problem hiding this comment.
@AbhiPrasad I opened my PR mostly because I keep the logger here. You removed this on your branch. What's expected?
|
After discussion, |
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loggerand typeLoggerwere deprecated in v9, usedebugand typeSentryDebugLoggerinstead.