ci(e2e): Only run changed E2E tests

[chargome]

This pr changes the detection logic for the e2e tests directory.

Before we always ran every test whenever something changed in this dir.
With this change we check for changed files in the test apps and only run all tests if shared code has been changed.

[mydea]

IMHO it's a bit weird/unexpected to use some and then collect stuff there 🤔

I think it would be easier to read/follow to extract this into a method like:

function getChangedTestApps(): false | Set<string>

And then do

const changedApps = getChangedTestApps();
if (!changedApps) {
  return testApplication;
}
// return the changed apps only...

[chargome]

I can move that into a function but would probably still make use of some so the loop stop whenever we have a match?

[chargome]

refactored a bit and replaced some with a basic for loop, hope that's more readable!

[cursor]

Bug: Shared Code Changes Ignored in Test Coverage

Files placed directly in dev-packages/e2e-tests/test-applications/ (not within a specific test app subdirectory) are incorrectly ignored by the getChangedTestApps function. This occurs because the slashIndex > 0 condition prevents processing files where indexOf('/') returns -1. These files, which are effectively shared code, should trigger a full test run (i.e., getChangedTestApps should return false), but their changes are currently missed, leading to incomplete test coverage.

dev-packages/e2e-tests/lib/getTestMatrix.ts#L196-L199

sentry-javascript/dev-packages/e2e-tests/lib/getTestMatrix.ts

Lines 196 to 199 in ff87af2

	if (slashIndex > 0) {
	changedTestApps.add(pathAfterPrefix.slice(0, slashIndex));
	}

Fix in Cursor • Fix in Web

---

Was this report helpful? Give feedback by reacting with 👍 or 👎