fix(node): Add mechanism to fastifyIntegration error handler
#17208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
requested review from
onurtemizkan,
a team,
mydea and
AbhiPrasad
and removed request for
a team and
mydea
Lms24
changed the title
fastifyIntegration error handler
AbhiPrasad
approved these changes
Jul 29, 2025
Lms24
added a commit
that referenced
this pull request
Jul 29, 2025
Marks the captured error as `{ handled: false, type: 'fastify' }`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating #17119, I saw that our fastifyIntegration error handler doesn't set a mechanism when calling
captureException. This leads to the SDK assigning the generic fallback mechanism and marking the error ashandled: true. This makes it hard to 1. identify that the error was captured by our fastify instrumentation and 2. marks the error as handled, when it's probably not.This PR now marks the captured error as
{ handled: false, type: 'fastify' }