Skip to content

Fix sentry-javascript issue 17183 #17225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

chargome
Copy link
Member

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

Fixes #17183 by preventing unnecessary rerenders of components wrapped with withErrorBoundary.

This is achieved by wrapping the component returned by withErrorBoundary with React.memo. A new test case has been added to verify that the wrapped component only rerenders when its props actually change.


Open in Cursor Open in Web

Learn more about Cursor Agents

@chargome chargome closed this Jul 30, 2025
@chargome chargome deleted the cursor/fix-sentry-javascript-issue-17183-4440 branch July 30, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

withErrorBoundary create unnecessary rerenders
2 participants