Skip to content

Address sentry-javascript issue 17183 with tests #17229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

chargome
Copy link
Member

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

Addresses #17183.

This PR optimizes the withErrorBoundary higher-order component by wrapping the WrappedComponent with React.memo. This prevents unnecessary rerenders of the wrapped component when its props have not changed, improving performance.

New tests have been added to verify that components wrapped with withErrorBoundary correctly memoize and only rerender when their props actually change.


Open in Cursor Open in Web

Learn more about Cursor Agents

@chargome chargome closed this Jul 30, 2025
@chargome chargome deleted the cursor/address-sentry-javascript-issue-17183-with-tests-cc33 branch July 30, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants