fix(react): Memoize wrapped component to prevent rerenders #17230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chargome
commented
Jul 30, 2025
andreiborza
reviewed
Jul 30, 2025
| @@ -96,6 +96,122 @@ describe('withErrorBoundary', () => { | |||
| const Component = withErrorBoundary(() => <h1>Hello World</h1>, { fallback: <h1>fallback</h1> }); | |||
| expect(Component.displayName).toBe(`errorBoundary(${UNKNOWN_COMPONENT})`); | |||
| }); | |||
|
|
|||
| it('does not rerender when props are identical', () => { | |||
There was a problem hiding this comment.
Tbh I think these tests are useless, you're just testing react api here. I think we don't need tests for this at all.
There was a problem hiding this comment.
I'd leave them in still, since they'll make sure we keep this memoized. But good point indeed
andreiborza
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cursor failed me on this one so fixing here.
closes #17183