fix(angular): If no other information is provided, fallback the request itself. #17293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| // If we don't have any detailed information, fallback to the request message itself. | ||
| return error.message; | ||
| // If we don't have any detailed information, fallback to the request itself. | ||
| return error; |
There was a problem hiding this comment.
Bug: Inconsistent Return Types Cause Runtime Errors
The function now returns inconsistent types: while other branches return formatted strings, the fallback case returns the entire error object instead of a string. This type inconsistency could cause runtime errors or unexpected behavior in calling code that expects a string.
Member
|
What exactly are you trying to fix here? Is there a problem with the current approach? |
Lms24
reviewed
Aug 4, 2025
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
Agreed, this change needs more context for us to review. Please write a proper PR description (or link to an issue if there is one)
Author
|
I thought the request itself should be logged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no other information is provided, fallback to the request itself.
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).