feat(node): Capture SystemError context and remove paths from message
#17331
+164
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
AbhiPrasad
reviewed
Aug 5, 2025
| for (const exception of event.exception?.values || []) { | ||
| if (exception.value) { | ||
| if (error.path && exception.value.includes(error.path)) { | ||
| exception.value = exception.value.replace(`'${error.path}'`, '').trim(); |
There was a problem hiding this comment.
I wonder if we should expose an integration option to control this replacement as well
There was a problem hiding this comment.
Ideally I would have used util.getSystemErrorMessage(err) to get the plain message without the paths but it was only added in Node v22
| @@ -32,6 +32,7 @@ import { onUncaughtExceptionIntegration } from '../integrations/onuncaughtexcept | |||
| import { onUnhandledRejectionIntegration } from '../integrations/onunhandledrejection'; | |||
| import { processSessionIntegration } from '../integrations/processSession'; | |||
| import { INTEGRATION_NAME as SPOTLIGHT_INTEGRATION_NAME, spotlightIntegration } from '../integrations/spotlight'; | |||
| import { systemErrorIntegration } from '../integrations/systemError'; | |||
There was a problem hiding this comment.
we'll have to export this from all of our node packages as well
size-limit report 📦
|
mydea
changed the title
SystemError context and remove paths from messageSystemError context and remove paths from message
AbhiPrasad
approved these changes
Aug 7, 2025
…om:getsentry/sentry-javascript into timfish/feat/node-system-error-integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #17332
Node.js has a
SystemErrorerror class.This error type contains numerous properties which can be useful for debugging but it also includes many of them in the error message which stops fingerprinting from grouping these errors.
This PR adds a default enabled integration that copies the error properties to a new context and strips paths from the error message.
If the top-level
sendDefaultPiiis not enabled, thepathanddestproperties will not be included.