Skip to content

Conversation

andreiborza
Copy link
Member

@andreiborza andreiborza commented Aug 6, 2025

Commits like meta: Re-organize changelog to add v8 page tripped this up. Our changelog entries always follow meta(changelog) so we should just check for that.

Commits like `- meta: Re-organize changelog to add v8 page
([#17327](https://github.com/getsentry/sentry-javascript/pull/17327))` tripped
this up. Our changelog entries always follow `meta(changelog)` so we should just
check for that.
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is meta(changelog): required? A quick check revealed that most of us do it in this pattern but I mostly added PR titles messages like meta: Update changelog .... Just wondering if I was off and this is written down somewhere or the check would not always work just the other way around 😅

@andreiborza
Copy link
Member Author

Is meta(changelog): required? A quick check revealed that most of us do it in this pattern but I mostly added PR titles messages like meta: Update changelog .... Just wondering if I was off and this is written down somewhere or the check would not always work just the other way around 😅

According to

4. Open a PR with the title `meta(changelog): Update changelog for VERSION` against `master` branch.
but I'm not sure if that's a hard require...

I think it would make sense to make it one though so we can reliably get the changelogs. I would've missed a bunch of PRs if I hadn't noticed that the example above "breaks" the chain early.

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm yeah fair enough then :D

@andreiborza andreiborza merged commit e2579bb into develop Aug 7, 2025
36 checks passed
@andreiborza andreiborza deleted the ab/stricter-yarn-changelog-checks branch August 7, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants