ref: Make lastReleasePos checks for yarn changelog stricter
#17340
Conversation
Commits like `- meta: Re-organize changelog to add v8 page ([#17327](https://github.com/getsentry/sentry-javascript/pull/17327))` tripped this up. Our changelog entries always follow `meta(changelog)` so we should just check for that.
There was a problem hiding this comment.
Is meta(changelog): required? A quick check revealed that most of us do it in this pattern but I mostly added PR titles messages like meta: Update changelog .... Just wondering if I was off and this is written down somewhere or the check would not always work just the other way around 😅
According to but I'm not sure if that's a hard require...I think it would make sense to make it one though so we can reliably get the changelogs. I would've missed a bunch of PRs if I hadn't noticed that the example above "breaks" the chain early. |
Commits like
meta: Re-organize changelog to add v8 pagetripped this up. Our changelog entries always followmeta(changelog)so we should just check for that.