Skip to content

feat(bun): Export skipOpenTelemetrySetup option #17349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2025

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Aug 7, 2025

As raised in #16969, the Bun SDK doesn't currently export skipOpenTelemetrySetup in the SDK init options type, altghough the option can be correctly passed to the underlying NodeClient. This PR exports the option now.

#16969 (comment)

Copy link
Member

@s1gr1d s1gr1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You already wrote in the description that this option will be passed to the underlying Node integration. Will this also disable spans in this case? As this is connected with the spans option in the Http integration:

/**
* If set to false, do not emit any spans.
* This will ensure that the default HttpInstrumentation from OpenTelemetry is not setup,
* only the Sentry-specific instrumentation for request isolation is applied.
*
* If `skipOpenTelemetrySetup: true` is configured, this defaults to `false`, otherwise it defaults to `true`.
*/
spans?: boolean;

@Lms24
Copy link
Member Author

Lms24 commented Aug 7, 2025

yes, that's correct. Setting skipOpenTelemetrySetup will disable Sentry http spans automatically.
(verified this in my bun repro app as well)

@Lms24 Lms24 merged commit b4aad49 into develop Aug 7, 2025
36 checks passed
@Lms24 Lms24 deleted the lms/feat-bun-export-skipOpenTelemetrySetup branch August 7, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants