ref(node): Split up incoming & outgoing http handling #17358
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just splitting the code into multiple files to make it a bit easier to reason about things & update things in follow up PRs.
Also removing node-fetch types from node package (they are unused there?) and moving
http/index.ts
andnode-fetch/index.ts
to top level to avoid an otherwise empty folder.Also updates the
getRequestUrl
method for outgoing requests to actually handle ClientRequest properly, this was unnecessarily overloaded before.