feat(node): Update httpIntegration handling of incoming requests
#17371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
mydea
force-pushed
the
fn/ref-otel-incoming-request
branch
from
8d7f49c to
e798a09
Compare
Add tests that definitely show: 1. How get and post spans are captured 2. How URLs are handled with params and fragments
mydea
force-pushed
the
fn/ref-otel-incoming-request
branch
from
e798a09 to
57f8184
Compare
mydea
changed the base branch from
develop
to
fn/add-full-attribute-http-span-test
mydea
commented
Aug 11, 2025
| const runner = createRunner(__dirname, 'server.js') | ||
| .expect({ | ||
| transaction: { | ||
| transaction: 'GET /test/:id/span-updateName-source', | ||
| transaction: 'new-name', |
There was a problem hiding this comment.
this is actually... fixed here now? Not quite sure why/how, but apparently some timing stuff is better now?
mydea
force-pushed
the
fn/ref-otel-incoming-request
branch
2 times, most recently
from
c882fb0 to
356461f
Compare
mydea
force-pushed
the
fn/ref-otel-incoming-request
branch
from
2f90c3c to
c120396
Compare
Base automatically changed from
fn/add-full-attribute-http-span-test
to
develop
August 11, 2025 13:00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the handling of the Node SDK of incoming requests. Instead of relying on @opentelemetry/instrumentation-http for this, we now handle this internally, ensuring that we can optimize performance as much as possible and avoid interop problems. This will also allow us to extract this out of an OTEL instrumentation, eventually paving the way for a non-OTEL SDK with basic tracing capabilities.
This change should not affect users, unless they are relying on very in-depth implementation details. Importantly, this also drops the
_experimentalConfigoption of the integration - this will no longer do anything.Finally, you can still pass
instrumentation.{requestHook,responseHook,applyCustomAttributesOnSpan}options, but they are deprecated and will be removed in v11. Instead, you can use the newincomingRequestSpanHookconfiguration option if you want to adjust the incoming request span.I have tried to ensure the spans look as similar as possible as before, I still may need to tweak a few attributes here or there though, I'll try to make a before and after comparison!
On top of #17373