test(node): Ensure runner does not create unused tmp files #17392
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed locally that I sometimes got unexpected un-removed
tmp_xxx
dirs in node-integration tests. After some debugging, I figured out the reason: We clean the tmp dir up inafterAll
of the test. However, if all tests inside are skipped,afterAll
is not executed. So if you run tests in a filtered way - e.g.yarn test -t "xxx"
- it would create the tmp dirs, but not delete them.This PR fixes this by moving the creation of the tmp dir into
beforeAll
, which equally is not executed when all tests are skipped.