feat(astro): Align options with shared build time options type #17396
+394
−136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| bundleSizeOptimizations, | ||
| unstable_sentryVitePluginOptions, |
There was a problem hiding this comment.
Bug: Sentry Vite Plugin Misinterprets Configuration Options
New top-level build-time options (e.g., org, project, authToken, sentryUrl, headers, telemetry, silent, errorHandler) are not destructured from the options object. This causes them to be incorrectly included in otherOptions, triggering a deprecation warning for 'additional options'. As a result, misleading warnings appear in production builds, despite these options being valid and used for Sentry Vite plugin configuration.
chargome
reviewed
Aug 13, 2025
| */ | ||
| bundleSizeOptimizations?: BundleSizeOptimizationOptions; |
There was a problem hiding this comment.
Am I confused or did this disappear with the changes? 🤔
There was a problem hiding this comment.
This is part of the shared type so it's possible to delete it here :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Astro currently mixes build-time and runtime options, the
releaseoption was omitted from the type. It's only possible to set this option with theunstable_sentryVitePluginOptions:(Closes #17067