-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feature(node): Add instrumentation to the handler in Hono #17428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
feature(node): Add instrumentation to the handler in Hono #17428
Conversation
… instead of function replacement
32e3a23
to
505c480
Compare
onSuccess(); | ||
} | ||
|
||
return result; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Promise Handling Flaws in _safeExecute
Method
The _safeExecute
method has a few issues with promise handling. It incorrectly detects thenable objects by checking for then
as an own property, which means spans for async handlers may end prematurely. Additionally, it returns the original promise while attaching new .then()
handlers, which can lead to unhandled rejections or inconsistent error flow. The method's return type annotation is also incorrect.
Summary
This PR enhances the Hono integration by adding comprehensive handler instrumentation, error handling capabilities, and thorough test coverage. The changes build upon the basic Hono integration to provide a complete tracing and error monitoring solution.
New Features
Bug Fixes
Implementation Details
Testing
Related Issue
close #15260