feat(flags): Adds Growthbook integration#17440
Conversation
|
@Lms24 Would you approve the workflows to run again? |
|
Tysm for the integration @madhuchavva !! Will take a look soon
For now Sentry is limiting all FF integrations to boolean only. We plan to rollout non-bool support later - would you mind removing those types from this PR? |
|
relates to getsentry/sentry#82157 |
packages/browser/src/integrations/featureFlags/growthbook/integration.ts
Outdated
Show resolved
Hide resolved
|
Changes lgtm but could use a review from the js experts for safety! I'm fine with node support getting added in a followup |
packages/browser/src/integrations/featureFlags/growthbook/integration.ts
Outdated
Show resolved
Hide resolved
packages/browser/src/integrations/featureFlags/growthbook/integration.ts
Outdated
Show resolved
Hide resolved
…egration' into feat/growthbook-integration
|
Thanks sm for the updates! Just approved tests to run. For server-side, I believe there are a few more pkgs to export from besides node. See https://github.com/getsentry/sentry-javascript/pull/16585/files as a reference - To verify it works for node, could we copy tests to |
6e459ee to
e1379ca
Compare
|
@AbhiPrasad do you mind taking a look at this? |
|
@madhuchavva once we fix CI: Build & Test / Lint we're good to go |
…egration' into feat/growthbook-integration
…egration' into feat/growthbook-integration
|
@aliu39 do you mind giving the approval to let the workflows run? |
@chargome Lint check is fixed now. Do you mind taking a look? |
|
|
@chargome Looks like there are other files than what's modified in this PR 🤔 in the error log? I don't see these errors locally when I run the |
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See #17440 Co-authored-by: chargome <20254395+chargome@users.noreply.github.com>
Co-authored-by: Charly Gomez <charly.gomez@sentry.io>
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See getsentry#17440 Co-authored-by: chargome <20254395+chargome@users.noreply.github.com>

Adds GrowthBook's integration for tracking feature evaluations.
This PR includes changes to wrap
isOn, getFeatureValue andevalFeaturemethods, record results of type (booleans, strings, numbers, null, objects/arrays) and attach them to active span or current scope buffer for errors.Closes https://linear.app/getsentry/issue/REPLAY-728/add-growthbook-feature-flag-integrations
Note
Adds GrowthBook integration that captures boolean feature evaluations via
isOn/getFeatureValueto spans and error events, and exports it across SDKs with browser/node tests.growthbookIntegration: WrapsisOn/getFeatureValueto capture boolean results; inserts into active span attributes and copies to error events via scope.@sentry/corefeature flags exports.growthbookIntegration.growthbookIntegration.onError(buffer eviction, updates, boolean-only capture, scope isolation) andonSpan(attributes on span end, per-span cap).onErrorandonSpan; add@growthbook/growthbooktest dependency.Written by Cursor Bugbot for commit 8fe30ac. This will update automatically on new commits. Configure here.